.NET/C#: stupid code of the day – Cosmos.Debug.VSDebugEngine

I wasn’t the first one to notice this one, but is hilereous:

bool enabled = fEnable == 0 ? false : true;

What about a simple logical negation (!) operator?

The above sample is from the “Visual Studio Debug Engine Sample” downloads.
And it is not there once, but 3 times!

<pre>File DebugEngineSample\Microsoft.VisualStudio.Debugger.SampleEngine\AD7.Impl\AD7BoundBreakpoint.cs:
54                  bool enabled = fEnable == 0 ? false : true;
60                  m_enabled = fEnable == 0 ? false : true;
File DebugEngineSample\Microsoft.VisualStudio.Debugger.SampleEngine\AD7.Impl\AD7PendingBreakpoint.cs:
183                     m_enabled = fEnable == 0 ? false : true;

Since the COSMOS people needed debugger support, it now is (temporarily) part of AD7BoundBreakpoint.cs adding code to the Cosmos.Debug.VSDebugEngine namespace on codeplex SVN.

Note that there are lots of on-line samples like this code.

It is worse than yoda-conditions :-)

–jeroen